tpm2_sessions_init() does not check the return value of
tpm2_create_null_primary(). Return on failure.

Fixes: d2add27cf2b8 ("tpm: Add NULL primary creation")
Signed-off-by: Jarkko Sakkinen <[email protected]>
---
 drivers/char/tpm/tpm2-sessions.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/char/tpm/tpm2-sessions.c b/drivers/char/tpm/tpm2-sessions.c
index 6cc1ea81c57c..d63510ad44ab 100644
--- a/drivers/char/tpm/tpm2-sessions.c
+++ b/drivers/char/tpm/tpm2-sessions.c
@@ -1288,8 +1288,10 @@ int tpm2_sessions_init(struct tpm_chip *chip)
        int rc;
 
        rc = tpm2_create_null_primary(chip);
-       if (rc)
+       if (rc) {
                dev_err(&chip->dev, "TPM: security failed (NULL seed 
derivation): %d\n", rc);
+               return rc;
+       }
 
        chip->auth = kmalloc(sizeof(*chip->auth), GFP_KERNEL);
        if (!chip->auth)
-- 
2.46.0


Reply via email to