Hi Stuart, kernel test robot noticed the following build warnings:
[auto build test WARNING on char-misc/char-misc-testing] [also build test WARNING on char-misc/char-misc-next char-misc/char-misc-linus rafael-pm/linux-next rafael-pm/bleeding-edge linus/master v6.14-rc2 next-20250214] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Stuart-Yoder/tpm_crb-implement-driver-compliant-to-CRB-over-FF-A/20250213-060938 base: char-misc/char-misc-testing patch link: https://lore.kernel.org/r/20250212220548.400447-2-stuart.yoder%40arm.com patch subject: [PATCH v2 1/5] tpm_crb: implement driver compliant to CRB over FF-A config: arm64-randconfig-r073-20250214 (https://download.01.org/0day-ci/archive/20250216/[email protected]/config) compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <[email protected]> | Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ smatch warnings: drivers/char/tpm/tpm_ffa_crb.c:272 ffa_crb_probe() warn: unsigned 'ffa_crb->minor_version' is never less than zero. vim +272 drivers/char/tpm/tpm_ffa_crb.c 230 231 static int ffa_crb_probe(struct ffa_device *ffa_dev) 232 { 233 int rc; 234 struct ffa_crb *p; 235 236 /* only one instance of a TPM partition is supported */ 237 if (ffa_crb && !IS_ERR_VALUE(ffa_crb)) 238 return -EEXIST; 239 240 ffa_crb = ERR_PTR(-ENODEV); // set ffa_crb so we can detect probe failure 241 242 if (!ffa_partition_supports_direct_recv(ffa_dev)) { 243 pr_err("TPM partition doesn't support direct message receive.\n"); 244 return -EINVAL; 245 } 246 247 p = kzalloc(sizeof(*ffa_crb), GFP_KERNEL); 248 if (!p) 249 return -ENOMEM; 250 ffa_crb = p; 251 252 mutex_init(&ffa_crb->msg_data_lock); 253 ffa_crb->ffa_dev = ffa_dev; 254 ffa_dev_set_drvdata(ffa_dev, ffa_crb); 255 256 /* if TPM is aarch32 use 32-bit SMCs */ 257 if (!ffa_partition_check_property(ffa_dev, FFA_PARTITION_AARCH64_EXEC)) 258 ffa_dev->ops->msg_ops->mode_32bit_set(ffa_dev); 259 260 /* verify compatibility of TPM service version number */ 261 rc = ffa_crb_get_interface_version(&ffa_crb->major_version, 262 &ffa_crb->minor_version); 263 if (rc) { 264 pr_err("failed to get crb interface version. rc:%d", rc); 265 goto out; 266 } 267 268 pr_info("ABI version %u.%u", ffa_crb->major_version, 269 ffa_crb->minor_version); 270 271 if ((ffa_crb->major_version != FFA_CRB_VERSION_MAJOR) || > 272 (ffa_crb->minor_version < FFA_CRB_VERSION_MINOR)) { 273 pr_err("Incompatible ABI version"); 274 goto out; 275 } 276 277 return 0; 278 279 out: 280 kfree(ffa_crb); 281 ffa_crb = ERR_PTR(-ENODEV); 282 return -EINVAL; 283 } 284 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
