On Wed, Jun 25, 2025 at 11:37:44AM +0100, Yeoreum Yun wrote:
> Hi Jarkkok,
>
> > > --- a/drivers/char/tpm/tpm_crb_ffa.c
> > > +++ b/drivers/char/tpm/tpm_crb_ffa.c
> > > @@ -115,6 +115,7 @@ struct tpm_crb_ffa {
> > > };
> > >
> > > static struct tpm_crb_ffa *tpm_crb_ffa;
> > > +static struct ffa_driver tpm_crb_ffa_driver;
> > >
> > > static int tpm_crb_ffa_to_linux_errno(int errno)
> > > {
> > > @@ -168,13 +169,23 @@ static int tpm_crb_ffa_to_linux_errno(int errno)
> > > */
> > > int tpm_crb_ffa_init(void)
> > > {
> > > + int ret = 0;
> > > +
> > > + if (!IS_MODULE(CONFIG_TCG_ARM_CRB_FFA)) {
> > > + ret = ffa_register(&tpm_crb_ffa_driver);
> > > + if (ret) {
> > > + tpm_crb_ffa = ERR_PTR(-ENODEV);
> > > + return ret;
> > > + }
> > > + }
> > > +
> > > if (!tpm_crb_ffa)
> > > - return -ENOENT;
> > > + ret = -ENOENT;
> > >
> > > if (IS_ERR_VALUE(tpm_crb_ffa))
> > > - return -ENODEV;
> > > + ret = -ENODEV;
> > >
> > > - return 0;
> > > + return ret;
> > > }
> > > EXPORT_SYMBOL_GPL(tpm_crb_ffa_init);
> > >
> > > @@ -369,7 +380,9 @@ static struct ffa_driver tpm_crb_ffa_driver = {
> > > .id_table = tpm_crb_ffa_device_id,
> > > };
> > >
> > > +#ifdef MODULE
> > > module_ffa_driver(tpm_crb_ffa_driver);
> > > +#endif
> > >
> > > MODULE_AUTHOR("Arm");
> > > MODULE_DESCRIPTION("TPM CRB FFA driver");
> > > --
> > > LEVI:{C3F47F37-75D8-414A-A8BA-3980EC8A46D7}
> > >
> >
> > NAK
>
> If you NACK with your comment on the cover letter,
> Would you check the my comments please?
>
> Actually, this wouldn't be fixed with the Kconfig.
I got into the same page (see my response to your response at 0/2) :-)
Thanks for the patience.
>
> Thanks
>
> --
> Sincerely,
> Yeoreum Yun
BR, Jarkko
