On Tue, Aug 12, 2025 at 05:13:32PM -0400, Denis Aleksandrov wrote: > Hi Jarkko, > > Thanks again for taking the time to review this patch. > > Regarding the `Closes:` tag warning, this issue is linked to an internal Red > Hat page, which is why > it was omitted. Therefore, this warning might need to be ignored. > > For the other warnings, I considered using either symbolic or octal > permissions > before submitting the > patch. I decided on symbolic permissions because that style is used > consistently throughout > `drivers/char/tpm/tpm_ppi.c`. > > When I tried changing the permissions to octal format, `scripts/checkpatch.pl > --strict` still flagged those > lines with the following warnings: > > ``` > WARNING: Reported-by: should be immediately followed by Closes: with a URL to > the report > #13: > Reported-by: Jan Stancek <jstan...@redhat.com> > Signed-off-by: Denis Aleksandrov <dalek...@redhat.com>
Lemme check today, if I could give some feedback and help out with this. BTW could you use plain text in your emails? I know kernel people who drop automatically HTML on this address. It's cool, I'm tolerant but it's the standard :-) There's a page for this too: https://www.kernel.org/doc/html/latest/process/email-clients.html Also, vger drops HTML mails, meaning that this response will arrive there but your response that I'm responding most likely not (at least vger used behave this way). BR, Jarkko
