On Wed, Sep 10, 2025 at 1:09 PM Jarkko Sakkinen <jar...@kernel.org> wrote: > > On Tue, Sep 02, 2025 at 03:12:45PM -0400, Denis Aleksandrov wrote: > > Great, thank you Jarkko! > > > > Could you please take a look at the most recent reply from Paul in the > > v2 thread for this patch? > > Should I move forward with the advised changes and send a v5? > > Mind passing me the lore link? At least quick search could not find > (sorry). >
Here is the link: https://lore.kernel.org/linux-integrity/20250827022102.17731-1-dalek...@redhat.com/t/#u My apologies for not including it earlier. > > > > The concerns were: > > - Adding info on how to test and debug the code to the commit message. > > - Reverting the "Blocked by OS ..." field in tpm_ppi_info[]. > > - Reverting the conditional in tpm_show_tcg/vs_operations() > > and sending in a separate patch with the change. The change was > > concerning displaying the "Not Implemented" status by updating > > `ret > 0` to `ret >= 0` in the if statement. To be more clear on the last point, the suggestion was to revert this change and send it as a separate patch. > > > > Please let me know what you think. > > > > Thanks again, > > Denis > > > > BR, Jarkko > Thanks, Denis
