On Thu, 25 Sep 2025, Lee Jones wrote:
> On Wed, 17 Sep 2025 10:09:00 -0700, Nathan Chancellor wrote:
> > Commit 5c83b07df9c5 ("tpm: Add a driver for Loongson TPM device") has a
> > semantic conflict with commit 07d8004d6fb9 ("tpm: add bufsiz parameter
> > in the .send callback"), as the former change was developed against a
> > tree without the latter change. This results in a build error:
> >
> > drivers/char/tpm/tpm_loongson.c:48:17: error: initialization of 'int
> > (*)(struct tpm_chip *, u8 *, size_t, size_t)' {aka 'int (*)(struct
> > tpm_chip *, unsigned char *, long unsigned int, long unsigned int)'} from
> > incompatible pointer type 'int (*)(struct tpm_chip *, u8 *, size_t)' {aka
> > 'int (*)(struct tpm_chip *, unsigned char *, long unsigned int)'}
> > [-Wincompatible-pointer-types]
> > 48 | .send = tpm_loongson_send,
> > | ^~~~~~~~~~~~~~~~~
> > drivers/char/tpm/tpm_loongson.c:48:17: note: (near initialization for
> > 'tpm_loongson_ops.send')
> > drivers/char/tpm/tpm_loongson.c:31:12: note: 'tpm_loongson_send' declared
> > here
> > 31 | static int tpm_loongson_send(struct tpm_chip *chip, u8 *buf,
> > size_t count)
> > | ^~~~~~~~~~~~~~~~~
> >
> > [...]
>
> Applied, thanks!
>
> [1/1] tpm: loongson: Add bufsiz parameter to tpm_loongson_send()
> commit: 39377467669197b02479798f49e3f19344155dc9
Send for testing.
Will follow-up on the PR once complete.
--
Lee Jones [李琼斯]
