get_burstcount() can return -EBUSY on timeout. When this happens, the
function returns directly without releasing the locality that was
acquired at the beginning of tpm_tis_i2c_send().

Use goto out_err to ensure proper cleanup when get_burstcount() fails.

Fixes: aad628c1d91a ("char/tpm: Add new driver for Infineon I2C TIS TPM")
Signed-off-by: Alper Ak <[email protected]>
---
 drivers/char/tpm/tpm_i2c_infineon.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/char/tpm/tpm_i2c_infineon.c 
b/drivers/char/tpm/tpm_i2c_infineon.c
index bdf1f329a679..8b7d32de0b2e 100644
--- a/drivers/char/tpm/tpm_i2c_infineon.c
+++ b/drivers/char/tpm/tpm_i2c_infineon.c
@@ -544,8 +544,10 @@ static int tpm_tis_i2c_send(struct tpm_chip *chip, u8 
*buf, size_t bufsiz,
                burstcnt = get_burstcount(chip);
 
                /* burstcnt < 0 = TPM is busy */
-               if (burstcnt < 0)
-                       return burstcnt;
+               if (burstcnt < 0) {
+                       rc = burstcnt;
+                       goto out_err;
+               }
 
                if (burstcnt > (len - 1 - count))
                        burstcnt = len - 1 - count;
-- 
2.43.0


Reply via email to