Re: [PATCH 28/61] ecryptfs: update format strings for u64 i_ino

[Tyler Hicks]

On 2026-02-26 10:55:30, Jeff Layton wrote:
> Update format strings and local variable types in ecryptfs for the
> i_ino type change from unsigned long to u64.
> 
> Signed-off-by: Jeff Layton <jlay...@kernel.org>

Acked-by: Tyler Hicks <c...@tyhicks.com>

Tyler

> ---
>  fs/ecryptfs/crypto.c | 6 +++---
>  fs/ecryptfs/file.c   | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/ecryptfs/crypto.c b/fs/ecryptfs/crypto.c
> index 
> 3b59346d68c594fcd7e27bae87849d3e19eff56e..f25c9a49e251a591695a143f64d1a81c5211ec18
>  100644
> --- a/fs/ecryptfs/crypto.c
> +++ b/fs/ecryptfs/crypto.c
> @@ -1313,7 +1313,7 @@ int ecryptfs_read_metadata(struct dentry 
> *ecryptfs_dentry)
>               rc = ecryptfs_read_xattr_region(page_virt, ecryptfs_inode);
>               if (rc) {
>                       printk(KERN_DEBUG "Valid eCryptfs headers not found in "
> -                            "file header region or xattr region, inode 
> %lu\n",
> +                            "file header region or xattr region, inode 
> %llu\n",
>                               ecryptfs_inode->i_ino);
>                       rc = -EINVAL;
>                       goto out;
> @@ -1323,7 +1323,7 @@ int ecryptfs_read_metadata(struct dentry 
> *ecryptfs_dentry)
>                                               
> ECRYPTFS_DONT_VALIDATE_HEADER_SIZE);
>               if (rc) {
>                       printk(KERN_DEBUG "Valid eCryptfs headers not found in "
> -                            "file xattr region either, inode %lu\n",
> +                            "file xattr region either, inode %llu\n",
>                               ecryptfs_inode->i_ino);
>                       rc = -EINVAL;
>               }
> @@ -1335,7 +1335,7 @@ int ecryptfs_read_metadata(struct dentry 
> *ecryptfs_dentry)
>                              "crypto metadata only in the extended attribute "
>                              "region, but eCryptfs was mounted without "
>                              "xattr support enabled. eCryptfs will not treat "
> -                            "this like an encrypted file, inode %lu\n",
> +                            "this like an encrypted file, inode %llu\n",
>                               ecryptfs_inode->i_ino);
>                       rc = -EINVAL;
>               }
> diff --git a/fs/ecryptfs/file.c b/fs/ecryptfs/file.c
> index 
> 7929411837cf5b2e98e1d4288791d2e07c44a4eb..49b0fbe0428a2d202434ce4b5fd7d82d2a63cf58
>  100644
> --- a/fs/ecryptfs/file.c
> +++ b/fs/ecryptfs/file.c
> @@ -253,7 +253,7 @@ static int ecryptfs_open(struct inode *inode, struct file 
> *file)
>       if (rc)
>               goto out_put;
>       ecryptfs_printk(KERN_DEBUG, "inode w/ addr = [0x%p], i_ino = "
> -                     "[0x%.16lx] size: [0x%.16llx]\n", inode, inode->i_ino,
> +                     "[0x%.16llx] size: [0x%.16llx]\n", inode, inode->i_ino,
>                       (unsigned long long)i_size_read(inode));
>       goto out;
>  out_put:
> 
> -- 
> 2.53.0
>