applesmc is very old, and all of its code is lumped into one
driver. Fan control, sensors, the light sensor, the motion
sensor and the keyboard backlight in a single file
with its own way of talking to the SMC. It is hard to extend
and to support new machines.
This series adds Intel Mac support to the macsmc drivers that
were written for Apple Silicon (the Asahi implementation).
The SMC works the same way on both platforms, so we share a
lot of code with Asahi. Only the way of talking to the SMC
differs.
To make that work, patch 1 splits the macsmc driver into a
common core and a backend. The existing RTKit code moves into
its own backend. Patch 2 adds an ACPI backend for Intel Macs
with I/O port, MMIO and interrupt support. After that, each
function gets its own small driver using the standard kernel
interfaces (hwmon, IIO, LEDs, power supply, RTC, watchdog),
instead of one large driver doing everything.
On Intel Macs these drivers replace applesmc (hwmon, light
sensor, motion sensor and keyboard backlight) and acpi-sbs
(battery and adapter). They are mutually exclusive with the
drivers they replace, so only one is used at a time.
This is an RFC to get early feedback on the design. The macsmc
split and the Intel Mac backend touch fundamental parts, so I
would rather change them now if maintainers ask. After that I
will test the series on more macsand send it upstream as a
proper series.
The series is organised as follows:
1 Split macsmc into a core and backends
2 ACPI backend for Intel Macs
3-6 New drivers: watchdog, IIO light and accelerometer,
keyboard backlight LED
7-9 RTC support for T2 Macs, a T2 detection flag, and
disabling the broken ACPI RTCs
10-11 Power supply support, replacing acpi-sbs
12-13 hwmon support for Intel Macs
14 ioctl for userspace access to SMC keys
Tested-on: MacBookPro16,1 , iMac20,1 , MacBookAir4,2 , MacBookPro12,1 ,
MacBookPro15,1
NOTE: Almost all drivers have been tested except the motion sensor
driver as i was not able to find any device that had one.
Atharva Tiwari (14):
treewide: Add backend for macsmc
platform/x86: add backend for macsmc in intel macs
watchdog: add driver for apple smc
iio/light: add new driver for macsmc
iio/accel: add driver for apple SMS
leds: add support for macsmc kbl
rtc: add support for x86 macs in macsmc-rtc
treewide: Add a flag to detect the Apple T2 chip
treewide: disable other rtc's in t2 macs
power/supply: add support for x86 macs in macsmc-power
acpi: disable battery and adapter for x86 apple machines
hwmon/macsmc: add more types
hwmon: add support for x86 macs in macsmc-hwmon
mfd/macsmc: add ioctl to access smc keys
MAINTAINERS | 2 +-
arch/x86/kernel/quirks.c | 37 +
drivers/acpi/acpi_tad.c | 4 +
drivers/acpi/sbs.c | 17 +-
drivers/acpi/x86/utils.c | 4 +
drivers/gpio/Kconfig | 2 +-
drivers/gpio/gpio-macsmc.c | 13 +-
drivers/hwmon/Kconfig | 7 +-
drivers/hwmon/macsmc-hwmon.c | 1126 ++++++++++++++++-
drivers/iio/accel/Kconfig | 10 +
drivers/iio/accel/Makefile | 1 +
drivers/iio/accel/macsmc-accel.c | 248 ++++
drivers/iio/light/Kconfig | 11 +
drivers/iio/light/Makefile | 1 +
drivers/iio/light/macsmc-light.c | 189 +++
drivers/leds/Kconfig | 11 +
drivers/leds/Makefile | 1 +
drivers/leds/leds-macsmc.c | 69 +
drivers/mfd/Kconfig | 15 +-
drivers/mfd/Makefile | 2 +-
drivers/mfd/macsmc-core.c | 362 ++++++
drivers/platform/x86/Kconfig | 10 +
drivers/platform/x86/Makefile | 1 +
drivers/platform/x86/macsmc-acpi.c | 642 ++++++++++
drivers/power/reset/Kconfig | 2 +-
drivers/power/supply/Kconfig | 2 +-
drivers/power/supply/macsmc-power.c | 751 ++++++++---
drivers/rtc/Kconfig | 2 +-
drivers/rtc/rtc-cmos.c | 4 +
drivers/rtc/rtc-macsmc.c | 126 +-
drivers/soc/apple/Kconfig | 14 +
drivers/soc/apple/Makefile | 2 +
.../macsmc.c => soc/apple/macsmc-rtkit.c} | 185 ++-
drivers/watchdog/Kconfig | 11 +
drivers/watchdog/Makefile | 2 +-
drivers/watchdog/macsmc_wdt.c | 140 ++
include/linux/mfd/macsmc.h | 104 +-
include/linux/platform_data/x86/apple.h | 5 +
.../platform_certs/keyring_handler.h | 8 -
security/integrity/platform_certs/load_uefi.c | 38 +-
40 files changed, 3786 insertions(+), 395 deletions(-)
create mode 100644 drivers/iio/accel/macsmc-accel.c
create mode 100644 drivers/iio/light/macsmc-light.c
create mode 100644 drivers/leds/leds-macsmc.c
create mode 100644 drivers/mfd/macsmc-core.c
create mode 100644 drivers/platform/x86/macsmc-acpi.c
rename drivers/{mfd/macsmc.c => soc/apple/macsmc-rtkit.c} (70%)
create mode 100644 drivers/watchdog/macsmc_wdt.c
--
2.55.0
