Bj�rn Mork wrote :
>
> well, I still need the attached patch to get smc-ircc working on my
> Compaq Armada M300. I don't know if a parameter is the best way to
> support controllers on non-default addresses, but at least it won't
> break anything else.
>
>
> Bj�rn
Well, I don't really know what to do about this patch.
One thing that I don't like about this patch is that the next
user of a Armada will have to do some guessing and searching to know
what is the configuration address. The code probe 4 different
addresses, so why not a fifth one ? At least, you could tell us what
the magic address is (maybe it's standard after all)...
Well, I'm also looking for somebody to take ownership of this
driver. I don't have the hardware, so I can't test, and the only way
to make sure to driver still work is to ignore all patches.
Stefani, your name is in the driver, so I guess by default it
will fall on you ;-) Or maybe Bj�rn you want to be the one...
Have fun...
Jean
> --- linux/drivers/net/irda/smc-ircc.c~ Fri Aug 17 14:40:54 2001
> +++ linux/drivers/net/irda/smc-ircc.c Fri Aug 17 14:44:47 2001
> @@ -158,6 +158,7 @@
> static int ircc_dma=255;
> static int ircc_fir=0;
> static int ircc_sir=0;
> +static int ircc_cfg=0;
>
> static unsigned short dev_count=0;
>
> @@ -393,6 +394,13 @@
> return -ENODEV;
> }
>
> + /* try user provided configuration register base address */
> + if (ircc_cfg>0) {
> + MESSAGE(" Overriding configuration address 0x%04x\n", ircc_cfg);
> + if (!smc_superio_fdc(ircc_cfg))
> + ret=0;
> + }
> +
> /* Trys to open for all the SMC chipsets we know about */
>
> IRDA_DEBUG(0, __FUNCTION__
> @@ -1227,5 +1235,7 @@
> MODULE_PARM_DESC(ircc_fir, "FIR Base Address");
> MODULE_PARM(ircc_sir, "1-4i");
> MODULE_PARM_DESC(ircc_sir, "SIR Base Address");
> +MODULE_PARM(ircc_cfg, "1-4i");
> +MODULE_PARM_DESC(ircc_cfg, "Configuration register base address");
>
> #endif /* MODULE */
_______________________________________________
Linux-IrDA mailing list - [EMAIL PROTECTED]
http://www.pasta.cs.UiT.No/mailman/listinfo/linux-irda
