Jean Tourrilhes <[EMAIL PROTECTED]> writes:
> One thing that I don't like about this patch is that the next
> user of a Armada will have to do some guessing and searching to know
> what is the configuration address. The code probe 4 different
> addresses, so why not a fifth one ? At least, you could tell us what
> the magic address is (maybe it's standard after all)...
The address is 0xe0. I agree that it probably should be added if it's
the only address missing. But as far as I can understand from the data
sheet, these chips can be put almost anywhere the PC manufacturer
wants. I am not convinced that Compaq is the only one abusing this
feature.
My original thought was to be very conservative regarding probing from
the driver, and instead add additional probes to findchip. That way an
Armada user should be able to find the magic address from the output
of findchip. But I was mainly doing this because I have no knowledge
of driver programming at all and didn't want to screw up somebodys
system....
Here's the alternative approach if you prefer that (also fixing a typo):
--- linux-2.4.10/drivers/net/irda/smc-ircc.c~ Wed Oct 3 15:27:26 2001
+++ linux-2.4.10/drivers/net/irda/smc-ircc.c Wed Oct 3 15:31:21 2001
@@ -127,7 +127,7 @@
{ "37M707", KEY55_1|SIR|SERx4, 0x42, 0x00 },
{ "37M81X", KEY55_1|SIR|SERx4, 0x4d, 0x00 },
{ "37N958FR", KEY55_1|FIR|SERx4, 0x09, 0x04 },
- { "37N972", KEY55_1|FIR|SERx4, 0x0a, 0x00 },
+ { "37N971", KEY55_1|FIR|SERx4, 0x0a, 0x00 },
{ "37N972", KEY55_1|FIR|SERx4, 0x0b, 0x00 },
{ NULL }
};
@@ -401,6 +401,8 @@
if (!smc_superio_fdc(0x3f0))
ret=0;
if (!smc_superio_fdc(0x370))
+ ret=0;
+ if (!smc_superio_fdc(0xe0))
ret=0;
if (!smc_superio_lpc(0x2e))
ret=0;
> Well, I'm also looking for somebody to take ownership of this
> driver. I don't have the hardware, so I can't test, and the only way
> to make sure to driver still work is to ignore all patches.
> Stefani, your name is in the driver, so I guess by default it
> will fall on you ;-) Or maybe Bj�rn you want to be the one...
I am afraid I am not up to that task. I am just no programmer. Let's
hope Stefani can do it.
Bj�rn
_______________________________________________
Linux-IrDA mailing list - [EMAIL PROTECTED]
http://www.pasta.cs.UiT.No/mailman/listinfo/linux-irda
