2006-09-04: EV dixit: > Keith's libkarma rids-libkarma-hg113.patch looks good to me > (more tests still pending).
Unfortunately, it is not correct yet. Now "rid" gets correctly computed, but "length" and "duration" not; at least not for mp3 files (I'll try with .ogg files later today). The bad news are that a shrinked temproal copy of the file does not allow to compute the duration for Variable Bit Rate (VBR) mp3 files correctly. Many applications, like mp3info, estimate an average bitrate by sampling a handful of frames and then use this estimate along with the file length to estimate the duration. For the moment, I've patched rio_rw.c so as to override the length property computed by lk_rio_update_props_from_tags with a correct file length. Then duration is computed from the bitrate provided by libtag. I hope libtag can compute an adequate bitrate estimate for VBR files (I don't have VBR files to test with); otherwise, the duration will be wrong for VBR MP3 files. The RK needs duration for scrolling and showing play progress. I'll send the patch this night, hopefully. Best, EV. ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ linux-karma-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-karma-devel
