Hi, Today I've been doing some more testing with the latest lkarmafs/libkarma versions. In particular I've been uploading quite a few .ogg files and som vbr (variable bit rate) .mp3 files. Happily enough, contrary to my fears ...
> 2006-09-04: EV dixit: > Unfortunately, it is not correct yet. Now "rid" gets correctly > computed, but "length" and "duration" not [...]. The bad news > are that a shrinked temporal copy of the file does not allow to > compute the duration for Variable Bit Rate (VBR) mp3 files > correctly. Many applications, like mp3info, estimate an > average bitrate by sampling a handful of frames and then use > this estimate along with the file length to estimate the > duration. > > For the moment, I've patched rio_rw.c so as to override the > length property computed by lk_rio_update_props_from_tags with a > correct file length. Then duration is computed from the bitrate > provided by libtag. I hope libtag can compute an adequate > bitrate estimate for VBR files (I don't have VBR files to test > with); otherwise, the duration will be wrong for VBR MP3 files. > > The RK needs duration for scrolling and showing play progress. ... everything seems to work prety well. I've found, however, a lkarmafs bug which makes lk_rename() incorrectly set a fixed (and wrong) bitrate in the moved tune. The fix is easy and will be included in the next release. If someone wants to fix it now, please ask and I'll send the patch. ---------------------------- Just for Keith and/or Franky: please remember that my libkarma patch to fix update_props_from_tags length and duration errors needs to be revised by someone who is familiar with libtag: 2006-09-06: EV dixit: > [...] I take the rio_cp.c modifications just as temporary > workarounds to allow me finishing lkarmafs-0.1.9. As such, > I've clearly marked the modified parts [...] Regards, EV. ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ linux-karma-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-karma-devel
