It's really a problem,if we remove MMC_CAP_4_BIT_DATA,then SD has to be set to 1 bit mode as well.
Cliff -----Original Message----- From: Mike Frysinger [mailto:[EMAIL PROTECTED] Sent: Thursday, December 20, 2007 2:22 PM To: [EMAIL PROTECTED] Cc: [email protected] Subject: Re: [Linux-kernel-commits] [4057] trunk/drivers/mmc/core/mmc.c: bug[#3535] BF54x sdh only support 1 bit MMC ,so if the inserted card is MMC, disable 4 bit mode On Dec 19, 2007 11:21 PM, <[EMAIL PROTECTED]> wrote: > Revision 4057 Author cliff Date 2007-12-19 22:20:53 -0600 (Wed, 19 > Dec > 2007) > Log Message bug[#3535]BF54x sdh only support 1 bit MMC ,so if the > inserted card is MMC,disable 4 bit mode > > trunk/drivers/mmc/core/mmc.c we cant go around hacking on common code because our hardware/drivers are inferior > --- trunk/drivers/mmc/core/mmc.c 2007-12-20 02:34:17 UTC (rev 4056) > +++ trunk/drivers/mmc/core/mmc.c 2007-12-20 04:20:53 UTC (rev 4057) > @@ -358,6 +358,9 @@ > /* > * Activate wide bus (if supported). > */ > +/*Currently,Blackfin 54x only support 1 bit MMC,while support 4 bit > +SD */ /*So if card type is MMC don't enable 4 bit mode*/ #if > +!defined(CONFIG_BF54x) > if ((card->csd.mmca_vsn >= CSD_SPEC_VER_4) && (host->caps & > MMC_CAP_4_BIT_DATA)) { err = mmc_switch(card, EXT_CSD_CMD_SET_NORMAL, > @@ -367,7 +370,7 @@ > > mmc_set_bus_width(card->host, MMC_BUS_WIDTH_4); } > - > +#endif if we cant do 4 bit mmc, then remove MMC_CAP_4_BIT_DATA from the Blackfin caps in host/bfin_sdh.c -mike _______________________________________________ Linux-kernel-commits mailing list [email protected] http://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
