Yes ,refer to:BF54x_Blackfin_Processor_Peripheral_Hardware_Reference.There is only one chance to tell common level that if we support 4 bit mode or not,but that time We don't know which card type it is.Commom level is in charge of identifying card type and deciding if set host and the card to 4 bit mode. So,it's better to remove MMC_CAP_4_BIT_DATA?
Cliff -----Original Message----- From: Mike Frysinger [mailto:[EMAIL PROTECTED] Sent: Thursday, December 20, 2007 2:39 PM To: Cai, Cliff Cc: [EMAIL PROTECTED]; [email protected] Subject: Re: [Linux-kernel-commits] [4057] trunk/drivers/mmc/core/mmc.c: bug[#3535] BF54x sdh only support 1 bit MMC ,so if the inserted card is MMC, disable 4 bit mode On Dec 20, 2007 1:31 AM, Cai, Cliff <[EMAIL PROTECTED]> wrote: > It's really a problem,if we remove MMC_CAP_4_BIT_DATA,then SD has to > be set to 1 bit mode as well. so you're saying our hardware can only do 1-bit MMC but it can do 1-bit or 4-bit SD ? if that's the case, we need to expand the description of capabilities in a generic manner, not add host-specific ifdef's to common code. -mike _______________________________________________ Linux-kernel-commits mailing list [email protected] http://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
