>-----Original Message-----
>From: Mike Frysinger [mailto:[email protected]]
>Sent: Wednesday, March 04, 2009 3:09 AM
>To: [email protected]
>Cc: [email protected]
>Subject: Re: [Linux-kernel-commits] [6148] trunk/drivers/spi:
>task[4277] preliminary code for sport emulated spi driver
>
>On Tue, Mar 3, 2009 at 05:11, <[email protected]> wrote:
>> +static u16 sport_pin_req[][5] = { {P_SPORT0_DTPRI, P_SPORT0_TSCLK,
>> + P_SPORT0_DRPRI, P_SPORT0_RSCLK, 0},
>> + {P_SPORT1_DTPRI, P_SPORT1_TSCLK, P_SPORT1_DRPRI,
>> + P_SPORT1_RSCLK, 0} };
>
>we use the set of SPORT pins a lot ... probably worth a define
>in our portmux headers along the lines of P_SPORT0 ...
I think it's OK.
>> +static struct sport_param sport_params[2] = {
>> + {
>> + .err_irq = IRQ_SPORT0_ERROR,
>> + .regs = (struct sport_register *)SPORT0_TCR1,
>> + },
>> + {
>> + .err_irq = IRQ_SPORT1_ERROR,
>> + .regs = (struct sport_register *)SPORT1_TCR1,
>> + }
>> +};
>
>before the driver goes any further, please move this stuff to
>the platform resources.
Yes,I plan to move this stuff to board file later ,
we dont want yet another driver with
>outdated kconfig/source sport configs.
>-mike
>
Did you mean we shoudn't configure sport,such as port number selection,
in Kconfig?
Cliff
_______________________________________________
Linux-kernel-commits mailing list
[email protected]
http://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
