On Tue, Mar 3, 2009 at 21:16, Cai, Cliff wrote: >From: Mike Frysinger [mailto:[email protected]] >>On Tue, Mar 3, 2009 at 05:11, <[email protected]> wrote: >>> +static struct sport_param sport_params[2] = { >>> + { >>> + .err_irq = IRQ_SPORT0_ERROR, >>> + .regs = (struct sport_register *)SPORT0_TCR1, >>> + }, >>> + { >>> + .err_irq = IRQ_SPORT1_ERROR, >>> + .regs = (struct sport_register *)SPORT1_TCR1, >>> + } >>> +}; >> >>before the driver goes any further, please move this stuff to >>the platform resources. > > Yes,I plan to move this stuff to board file later ,
the problem is that "later" turns into "never" >> we dont want yet another driver with >>outdated kconfig/source sport configs. > > Did you mean we shoudn't configure sport,such as port number selection, > in Kconfig? correct. Kconfig should only be "enable driver". it cares nothing about which sport or how many. the platform resources declares that so we can easily get arbitrary combinations: - just sport0 - just sport1 - just sport2 - sport0 and sport2 - sport2 and sport3 there should be a one-to-one binding in the platform resources between a single sport and this new spi-sport driver. -mike _______________________________________________ Linux-kernel-commits mailing list [email protected] http://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
