Barry,
It breaks in spi.c spi_add_device()
>Which device?
ADF702x
>>bfin-spi bfin-spi.0: cs10 >= max 8
It used GPIO_PF10 - and since 10 > platform_info->num_chipselect
It breaks....
/**
* spi_add_device - Add spi_device allocated with spi_alloc_device
* @spi: spi_device to register
*
* Companion function to spi_alloc_device. Devices allocated with
* spi_alloc_device can be added onto the spi bus with this function.
*
* Returns 0 on success; negative errno on failure
*/
int spi_add_device(struct spi_device *spi)
{
static DEFINE_MUTEX(spi_add_lock);
struct device *dev = spi->master->dev.parent;
int status;
/* Chipselects are numbered 0..max; validate. */
if (spi->chip_select >= spi->master->num_chipselect) {
dev_err(dev, "cs%d >= max %d\n",
spi->chip_select,
spi->master->num_chipselect);
return -EINVAL;
}
-Michael
>-----Original Message-----
>From: Song, Barry
>Sent: Dienstag, 17. November 2009 11:20
>To: Hennerich, Michael; [email protected]; linux-kernel-
>[email protected]
>Subject: RE: [Linux-kernel-commits] [7832] trunk: bug [#5689],don't set
>select num as 0 while using gpio cs
>
>Which device? I tested on ad1938/ad1836, it can work.
>
>>-----Original Message-----
>>From: Hennerich, Michael [mailto:[email protected]]
>>Sent: Tuesday, November 17, 2009 6:12 PM
>>To: [email protected];
>>[email protected]
>>Subject: RE: [Linux-kernel-commits] [7832] trunk: bug
>>[#5689],don't set select num as 0 while using gpio cs
>>
>>Barry,
>>
>>Your fix doesn't work!
>>
>>brd: module loaded
>>bfin-spi bfin-spi.0: cs10 >= max 8
>>bfin-spi bfin-spi.0: Blackfin on-chip SPI Controller Driver,
>>Version 1.0, reg7
>>
>>-Michael
>>
>>
_______________________________________________
Linux-kernel-commits mailing list
[email protected]
https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
