On Tue, Nov 17, 2009 at 04:46, <[email protected]> wrote: > Revision 7832 Author bhsong Date 2009-11-17 04:45:59 -0500 (Tue, 17 Nov > 2009) > > Log Message > > bug [#5689], don't set select num as 0 while using gpio cs > > Modified: trunk/arch/blackfin/include/asm/bfin5xx_spi.h (7831 => 7832) > > @@ -109,6 +109,7 @@ > #define CMD_SPI_GET_SYSTEMCLOCK 25 > #define CMD_SPI_SET_WRITECONTINUOUS 26 > > +#define USE_GPIO_CS 0x8000 > /* device.platform_data for SSP controller devices */ > struct bfin5xx_spi_master { > u16 num_chipselect; > > Modified: trunk/arch/blackfin/mach-bf537/boards/stamp.c (7831 => 7832) > > @@ -987,7 +987,7 @@ > .max_speed_hz = 20000000, /* max spi clock (SCK) speed in > HZ */ > .irq = IRQ_PF6, > .bus_num = 0, > - .chip_select = 0, /* GPIO controlled SSEL */ > + .chip_select = GPIO_PF10 | USE_GPIO_CS, /* GPIO controlled SSEL > */ > .controller_data = &enc28j60_spi_chip_info, > .mode = SPI_MODE_0, > },
it seems wasteful and fragile to still use .cs_gpio to set GPIO_PF10 when the information is now encoded in .chip_select too. why dont we delete it from our platform structure and have the spi master driver worry about it. -mike _______________________________________________ Linux-kernel-commits mailing list [email protected] https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
