+               cf->can_id = ((readw(&reg->chl[RECEIVE_EXT_CHL].id1) & 0x1FFF)
+                               << 16) + readw(&reg->chl[RECEIVE_EXT_CHL].id0);

Do we really want to do 

CLI
NOP
NOP
SSYNC
READ
STI

On every System MMR access?
I don't think so please use bfin_readXX/bfin_writeXX.
Honestly I would switch to use only structs.
ANOMALY_05000198 is not present on any Blackfin derivates featuring a CAN 
controller.

-Michael  

_______________________________________________
Linux-kernel-commits mailing list
[email protected]
https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits

Reply via email to