>-----Original Message----- >From: Song, Barry >Sent: Freitag, 11. Dezember 2009 09:36 >To: Hennerich, Michael; [email protected]; linux-kernel- >[email protected] >Subject: RE: [Linux-kernel-commits] [7972] >trunk/drivers/net/can/bfin_can.c: bfin-can: cleanup according to >upstream feedback > > > >>-----Original Message----- >>From: Hennerich, Michael [mailto:[email protected]] >>Sent: Friday, December 11, 2009 4:28 PM >>To: [email protected]; >>[email protected] >>Subject: RE: [Linux-kernel-commits] [7972] >>trunk/drivers/net/can/bfin_can.c: bfin-can: cleanup according >>to upstream feedback >> >>+ cf->can_id = >>((readw(®->chl[RECEIVE_EXT_CHL].id1) & 0x1FFF) >>+ << 16) + >>readw(®->chl[RECEIVE_EXT_CHL].id0); >> >>Do we really want to do >> >>CLI >>NOP >>NOP >>SSYNC >>READ >>STI >> >>On every System MMR access? >>I don't think so please use bfin_readXX/bfin_writeXX. >>Honestly I would switch to use only structs. >>ANOMALY_05000198 is not present on any Blackfin derivates >>featuring a CAN controller. >Yes. I have said I want to use bfin_readXX/writeXX. But I just sent mail >to let the upstream to make sure he can accept.
Sorry - I saw your other post after I wrote this... -Michael >> >>-Michael >> >> _______________________________________________ Linux-kernel-commits mailing list [email protected] https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
