On Wed, Feb 3, 2010 at 04:15, <[email protected]> wrote:
> +static ssize_t ad715x_store_ch2_threshold(struct device *dev,
> + struct device_attribute *attr,
> + const char *buf,
> + size_t len)
> +{
> + if ((!ret) && (data < 0x10000)) {
done need those paren in all the places like this
> +static int __devinit ad715x_probe(struct i2c_client *client,
> + const struct i2c_device_id *id)
> +{
> ...
> + if (client->irq && gpio_is_valid(irq_to_gpio(client->irq)) > 0) {
shouldnt an error from gpio_is_valid() cause the probe() to abort ?
i'd say so ...
> + dev_err(&client->dev, "%s capacitive sensor registered, irq :%d\n",
> id->name, client->irq);
dev_info(), and isnt the name already part of the &dev output ? it
should be "irq: %d" rather than "irq :%d" ...
> +static int ad715x_remove(struct i2c_client *client)
__devexit ?
> + if (client->irq && gpio_is_valid(irq_to_gpio(client->irq)) > 0)
> + iio_unregister_interrupt_line(indio_dev, 0);
dont need the gpio_is_valid() check once probe() makes this a fatal error
> + .remove = ad715x_remove,
__devexit_p()
> +MODULE_DESCRIPTION("Analog Device ad715x capacitive sensor driver");
should be AD715x in description type strings (so the Kconfig too)
-mike
_______________________________________________
Linux-kernel-commits mailing list
[email protected]
https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
