>-----Original Message----- >From: Mike Frysinger [mailto:[email protected]] >Sent: Wednesday, February 03, 2010 5:47 PM >To: Song, Barry >Cc: [email protected]; >[email protected] >Subject: Re: [Linux-kernel-commits] [8267] trunk: taske >[#5868], New IIO driver for ad715x CDC devices > >On Wed, Feb 3, 2010 at 04:45, Song, Barry wrote: >>From: Mike Frysinger [mailto:[email protected]] >>>On Wed, Feb 3, 2010 at 04:15, <[email protected]> wrote: >>>> +static ssize_t ad715x_store_ch2_threshold(struct device *dev, >>>> + struct device_attribute *attr, >>>> + const char *buf, >>>> + size_t len) >>>> +{ >>>> + if ((!ret) && (data < 0x10000)) { >>> >>>done need those paren in all the places like this >> >> Sure. Is there a coding style requirement about that? Personally, I >> think paren makes more readable. >> Why let people to remember the precedence? > >the (!ret) is certainly useless, but the (data <...) i dont care much >about. if you want to leave it, that's fine. Both useless. In fact, many companies require "()" is added to expressions before and after && and ||. That is just a style issue.
>-mike > _______________________________________________ Linux-kernel-commits mailing list [email protected] https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
