+ if (spi->irq && gpio_is_valid(irq_to_gpio(spi->irq)) > 0) {I would remove the gpio_is_valid(irq_to_gpio(spi->irq)) check completely. Who says that spi->irq can't be something else than a GPIO interrupt? Also irq_to_gpio is not mandatorily implemented for GPIO interrupts attached to external GPIO controllers. -Michael _______________________________________________ Linux-kernel-commits mailing list [email protected] https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
