>-----Original Message-----
>From: Hennerich, Michael [mailto:[email protected]]
>Sent: Tuesday, March 09, 2010 6:33 PM
>To: [email protected];
>[email protected]
>Subject: RE: [Linux-kernel-commits] [8430]
>trunk/drivers/staging/iio/meter:[#5905], New IIO driver for ade77xx
>
>+ if (spi->irq && gpio_is_valid(irq_to_gpio(spi->irq)) > 0) {
>
>I would remove the gpio_is_valid(irq_to_gpio(spi->irq)) check
>completely.
>Who says that spi->irq can't be something else than a GPIO interrupt?
>Also irq_to_gpio is not mandatorily implemented for GPIO
>interrupts attached to external GPIO controllers.
gpio_is_valid() is redundant here. I just followed the style of existing
drivers. Of course, all can be deleted.
>
>-Michael
>
>
_______________________________________________
Linux-kernel-commits mailing list
[email protected]
https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
