On Thu, Sep 16, 2010 at 23:03, <[email protected]> wrote:
> +s8 port_mux[] = {
these need to be static & const
> +int portmuxgroup_check(unsigned short per)
these need to be static
> + pfunc = bfin_read_PORT_MUX();
excess space after the "="
> + printk(KERN_ERR "pin grounp conflict!"
> + "request pin %d func %d"
> + "conflict with pin %d func %d\n"
> + , ident, function,
> + m, pfunc);
use pr_err(), dont line wrap the string, and keep the comma after the
string cuddled
> + if ((gpio_bank(ident)*16 + pin) == ident)
> + if (is_reserved(peri, gpio_bank(ident)*16 + pin, 1)) {
> + gpio_bank(ident)*16 + pin,
should store that ident*16 value in a local variable so you dont have
to keep recalculating it
also, i'm guessing this "16" is based on the GPIO banksize, so you
should use the GPIO_BANKSIZE define
> +#if defined(CONFIG_BF52x) || defined(CONFIG_BF51x) || defined(BF537_FAMILY)
> + if (unlikely(portmuxgroup_check(per))) {
> + local_irq_restore_hw(flags);
> + return -EBUSY;
> + }
> +#endif
define portmuxgroup_check() for every variant, then we dont need this ifdef
-mike
_______________________________________________
Linux-kernel-commits mailing list
[email protected]
https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
