On Thu, Sep 16, 2010 at 23:03, <[email protected]> wrote: > +int portmuxgroup_check(unsigned short per) > +{ > + u16 m, ident, pfunc; > + s8 offset; > + u16 function = P_FUNCT2MUX(per); > + offset = port_mux[P_IDENT(per)]; > + ident = P_IDENT(per); > + for (m = 0; m < ARRAY_SIZE(port_mux); m++) { > + if (m == ident) > + continue; > + if (port_mux[m] == offset) {
taking another look at this chunk for the BF537 ... why do you need to loop over the indices of port_mux when you will only ever look at port_mux[m] when m == ident ? isnt the for loop useless when you already know the one index you're going to check ? -mike _______________________________________________ Linux-kernel-commits mailing list [email protected] https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
