On Thu, Oct 7, 2010 at 23:36, Bob Liu wrote: > On Fri, Oct 1, 2010 at 10:54 AM, Mike Frysinger wrote: >> On Thu, Sep 30, 2010 at 03:54, <[email protected]> wrote: >>> +config SND_BFIN_AD73311_RESET >>> + int "RESET pin for AD73311L Chip Select" >>> + depends on SND_BF5XX_SOC_AD73311 >>> + default 4 >>> + help >>> + Enter the GPIO used to control AD73311's RESET pin. Acceptable >>> + values are 0 to 7 >> >> we want to get away from kconfig values for device settings. >> especially since this limits things to 1 instance. i know other parts >> of this code also limits things (direct codec symbol manipulation), >> but with the next release or two of ASOC, there should be finally >> support for multiple codecs. which means we will have to revisit >> then. >> >> btw, why the 0...7 limit ? afaict, there is no limit at all here >> other than "valid GPIO #", and that goes without saying ... > > I think you are right but I am not sure. > I just simply copy it from the SND_BFIN_AD73311_SE define. > I don't know if there is some special reasons. > So fix it in the next release is okay?
oh, in that case i'm pretty sure it's historical. the AD73311 has been around for a long time and predates things like the GPIO framework and so the original implementation was tied to things like valid PORT pins (since the value was written directly to the MMRs) and specific Blackfin variants. delaying this work to post 2010R1 is fine. it basically boils down to moving this Kconfig to the platform resources and letting people set it to whatever GPIO value they wanted. -mike _______________________________________________ Linux-kernel-commits mailing list [email protected] https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
