On Thu, Sep 30, 2010 at 03:54, <[email protected]> wrote: > +static int snd_ad73311_reset(void) > +{ > + gpio_set_value(GPIO_RESET, 0); > + udelay(100); > + gpio_set_value(GPIO_RESET, 1); > +} > + > static int snd_ad73311_startup(void) > { > pr_debug("%s enter\n", __func__); > > /* Pull up SE pin on AD73311L */ > gpio_set_value(GPIO_SE, 1); > + udelay(1); > return 0; > }
the reset function has an "int" ret, but doesnt actually return a value. actually, both of these funcs are called in one place and their return value isnt checked. so i'd change both to a return type of "void". -mike _______________________________________________ Linux-kernel-commits mailing list [email protected] https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
