On Thu, May 5, 2011 at 02:27, Steven Miao <[email protected]> wrote:
> arch/blackfin/kernel/bfin_dma_5xx.c | 6 ++++++
> arch/blackfin/mach-bf537/include/mach/anomaly.h | 2 ++
> 2 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/arch/blackfin/kernel/bfin_dma_5xx.c
> b/arch/blackfin/kernel/bfin_dma_5xx.c
> index 6ce8dce..38a1093 100644
> --- a/arch/blackfin/kernel/bfin_dma_5xx.c
> +++ b/arch/blackfin/kernel/bfin_dma_5xx.c
> @@ -21,6 +21,7 @@
> #include <asm/dma.h>
> #include <asm/uaccess.h>
> #include <asm/early_printk.h>
> +#include <mach/cdefBF537.h>
why do you need to explicitly include this ? we've never had to
include a specific def/cdef before, and i'm pretty sure this just
broke all non-bf537 parts. this header is only at
arch/blackfin/mach-bf537/include/mach/cdefBF537.h, and that path is
only searched when configuring for bf537 parts.
> +#if defined(CONFIG_BF537) && ANOMALY_05000480
> + bfin_write_DMA_TC_PER(0x1111);
> +#endif
this wont work for bf534/bf536 parts. please use:
#ifdef BF537_FAMILY
if (ANOMALY_05000480)
bfin_write_DMA_TC_PER(0x1111);
#endif
> --- a/arch/blackfin/mach-bf537/include/mach/anomaly.h
> +++ b/arch/blackfin/mach-bf537/include/mach/anomaly.h
this should be added as a stub to all headers
-mike
_______________________________________________
Linux-kernel-commits mailing list
[email protected]
https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
