On Fri, Jul 15, 2011 at 04:45, Michael Hennerich wrote:
> + goto err_release_pwm ;
no space before that ";"
> --- /dev/null
> +++ b/include/linux/input/adux1001.h
>
> +struct adux1001_calib_data {
> + unsigned char slra_cal0;
> + unsigned char slra_cal1;
> + unsigned char slra_cal2;
> + unsigned char slra_cal3;
> + unsigned char slra_cal4;
> + unsigned char slra_cal5;
> +} __packed;
probably should add a comment that this struct has to match the
over-the-wire format the device expects
also, i think you need linux/compiler.h for __packed
> +struct adux1001_vibra_platform_data {
> + /* Actuator Selection: true = ERM, false = LRA */
> + bool actuator_is_erm;
the "bool" probably needs linux/types.h
> + int (*setup)(struct i2c_client *client,
> + unsigned state);
probably want to put a forward i2c_client struct decl at the top of
this file after the includes to avoid warnings here.
-mike
_______________________________________________
Linux-kernel-commits mailing list
[email protected]
https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits
