-----Original Message-----
From: [email protected] 
[mailto:[email protected]] On Behalf Of 
Hennerich, Michael
Sent: Monday, July 18, 2011 4:09 PM
To: Mike Frysinger
Cc: [email protected]
Subject: Re: [Linux-kernel-commits] input: misc: New driver for ADUX1001 Smart 
Electromagnetic Actuator Haptic Driver


>> +struct adux1001_vibra_platform_data {
>> +    /* Actuator Selection: true = ERM, false = LRA */
>> +    bool actuator_is_erm;
>
> the "bool" probably needs linux/types.h
>> +    int     (*setup)(struct i2c_client *client,
>> +                     unsigned state);
>
> probably want to put a forward i2c_client struct decl at the top of
> this file after the includes to avoid warnings here.
> -mike

Why not include <linux/i2c.h> directly?

Scott

--
Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368; 
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin, 
Margaret Seif


_______________________________________________
Linux-kernel-commits mailing list
[email protected]
https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits


_______________________________________________
Linux-kernel-commits mailing list
[email protected]
https://blackfin.uclinux.org/mailman/listinfo/linux-kernel-commits

Reply via email to