On Mon, Oct 26, 2015 at 10:49:19AM -0500, J. German Rivera wrote: > -error_cleanup_open: > +dprc_scan_container_error: > (void)dprc_close(mc_dev->mc_io, 0, mc_dev->mc_handle);
The error label was better in the original code. A "goto error_cleanup_open", that tells you what the goto does. "goto dprc_scan_container_error" tells you nothing because you can see from the line before that there was a container error. No new information. It's just like a function name tells you what a function does. You wouldn't name the function called_from_main(). regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
