On Wed, Oct 28, 2015 at 07:13:24PM +0100, Bogicevic Sasa wrote: > This fixes all Alignment should match open parenthesis > messages from checkpatch.pl > > Signed-off-by: Bogicevic Sasa <[email protected]> > --- > drivers/staging/gdm724x/gdm_lte.c | 69 > +++++++++++++++++++++++++-------------- > 1 file changed, 45 insertions(+), 24 deletions(-) > > diff --git a/drivers/staging/gdm724x/gdm_lte.c > b/drivers/staging/gdm724x/gdm_lte.c > index a8d2cff..a28e0d1 100644 > --- a/drivers/staging/gdm724x/gdm_lte.c > +++ b/drivers/staging/gdm724x/gdm_lte.c > @@ -161,12 +161,15 @@ static int gdm_lte_emulate_arp(struct sk_buff *skb_in, > u32 nic_type) > return -ENOMEM; > skb_reserve(skb_out, NET_IP_ALIGN); > > - memcpy(skb_put(skb_out, mac_header_len), mac_header_data, > + memcpy( > + skb_put(skb_out, mac_header_len), mac_header_data, > mac_header_len);
No. This isn't the right way. Look at other code to see how it's done. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

