Hi, Javi, thanks for your review, will send a version 3 out soon. > -----Original Message----- > From: Javi Merino [mailto:[email protected]] > Sent: Wednesday, October 28, 2015 6:40 PM > To: Chen, Yu C > Cc: Zhang, Rui; [email protected]; [email protected]; linux- > [email protected]; [email protected] > Subject: Re: [PATCH 3/3][v2] Thermal: do thermal zone update after a cooling > device registered > > Hi Yu, > > One minor nit below. Other than that you can add my > > Reviewed-by: Javi Merino <[email protected]> > > On Mon, Oct 26, 2015 at 11:15:30AM +0800, Chen Yu wrote: > > When a new cooling device is registered, we need to update the thermal > > zone to set the new registered cooling device to a proper state. > > > > This fixes a problem that the system is cool, while the fan devices > > are left running on full speed after boot, if fan device is registered > > after thermal zone device. > > > > Here is the history of why current patch looks like this: > > https://patchwork.kernel.org/patch/7273041/ > > > > CC: <[email protected]> #3.18+ > > Reference:https://bugzilla.kernel.org/show_bug.cgi?id=92431 > > Tested-by: Manuel Krause <[email protected]> > > Tested-by: szegad <[email protected]> > > Tested-by: prash <[email protected]> > > Tested-by: amish <[email protected]> > > Signed-off-by: Zhang Rui <[email protected]> > > Signed-off-by: Chen Yu <[email protected]> > > --- > > diff --git a/include/linux/thermal.h b/include/linux/thermal.h index > > 5bcabc7..4298418 100644 > > --- a/include/linux/thermal.h > > +++ b/include/linux/thermal.h > > @@ -195,6 +195,7 @@ struct thermal_zone_device { > > int emul_temperature; > > int passive; > > unsigned int forced_passive; > > + atomic_t need_update; > > Please document this field in the kernel-doc comment for struct > thermal_zone_device. >
Best Regards, Yu
