On Tue, Nov 10, 2015 at 9:51 AM, Jeff Moyer <[email protected]> wrote: > Jerry Hoemann <[email protected]> writes: > >> Add IOCTL type 'P' to denote NVDIMM_TYPE_PASSTHRU. > > Can't you just make passthrough a separate command? If you actually add > the ioctl definition for passthrough (which you didn't do for some > reason?), it looks odd: > > #define ND_IOCTL_PASSTHRU _IOWR(NVDIMM_TYPE_PASSTHRU,, > ND_CMD_PASSTHRU, \ > struct ndn_package) > > Care to comment on why you chose a different type instead of specifying > a new command?
+1 for making this just a new command number without a new top-level number space. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
