On Wed, Nov 11, 2015 at 9:48 PM, Sergei Shtylyov <[email protected]> wrote: > On 11/11/2015 10:03 PM, Andy Shevchenko wrote:
>> Won't comment precisely by line, but common nitpicks about style: >> - added empty lines where no need >> - redundant parens >> - pieces of code takes whole line when they are quite fit tail of >> previous one. >> >> And why malloc for 8 bytes? > It's a good tone to skip the parts you're not commenting on, so others > wouldn't have to scroll in vain. Isn't obvious from my comment that no scroll is needed? -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
