On Wed, Nov 18, 2015 at 02:43:34PM +0100, Marc Gonzalez wrote: > Since 'struct clocksource' is ____cacheline_aligned, gcc must insert > a lot of padding between reg and clksrc in 'struct clocksource_mmio' > (for example, L1_CACHE_BYTES = 64 on ARMv7). > > Storing reg within 'struct clocksource' removes unnecessary padding, > and reg can then be grouped with other hot data. A nice side-effect > of this patch is making container_of() unnecessary, which makes the > code a bit simpler. > > On 32-bit platforms, reg fits in the padding between read and mask, > meaning no downside from storing it there.
Just swap the order of 'reg' and 'clksrc'. -- FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/