Marc Gonzalez <marc_gonza...@sigmadesigns.com> writes: > Since 'struct clocksource' is ____cacheline_aligned, gcc must insert > a lot of padding between reg and clksrc in 'struct clocksource_mmio' > (for example, L1_CACHE_BYTES = 64 on ARMv7). > > Storing reg within 'struct clocksource' removes unnecessary padding, > and reg can then be grouped with other hot data.
Can you demonstrate a difference with this change? Not saying it's bad, but it's always good to have numbers. > A nice side-effect of this patch is making container_of() unnecessary, > which makes the code a bit simpler. You really need to get used to that construct. -- Måns Rullgård m...@mansr.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
