Hi Mathias,

[auto build test WARNING on: v4.4-rc1]
[cannot apply to: v4.4-rc3 v4.4-rc2 next-20151127]

url:    
https://github.com/0day-ci/linux/commits/Mathias-Nyman/xhci-fix-usb2-resume-timing-and-races/20151130-231438
config: i386-randconfig-r0-201548 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers/usb/host/xhci-hub.c: In function 'xhci_get_port_status':
>> drivers/usb/host/xhci-hub.c:812:52: warning: suggest parentheses around '&&' 
>> within '||' [-Wparentheses]
          (raw_port_status & PORT_PLS_MASK) != XDEV_U3 &&
                                                       ^

vim +812 drivers/usb/host/xhci-hub.c

   796                          bus_state->suspended_ports &= ~(1 << wIndex);
   797                  } else {
   798                          /*
   799                           * The resume has been signaling for less than
   800                           * 20ms. Report the port status as SUSPEND,
   801                           * let the usbcore check port status again
   802                           * and clear resume signaling later.
   803                           */
   804                          status |= USB_PORT_STAT_SUSPEND;
   805                  }
   806          }
   807          /* Clear stale usb2 resume signalling variables in case port 
changed
   808           * state during 20ms resume signalling. For example on error
   809           */
   810          if ((bus_state->resume_done[wIndex] ||
   811               test_bit(wIndex, &bus_state->resuming_ports) &&
 > 812               (raw_port_status & PORT_PLS_MASK) != XDEV_U3 &&
   813               (raw_port_status & PORT_PLS_MASK) != XDEV_RESUME)) {
   814                  bus_state->resume_done[wIndex] = 0;
   815                  clear_bit(wIndex, &bus_state->resuming_ports);
   816          }
   817          if ((raw_port_status & PORT_PLS_MASK) == XDEV_U0
   818                          && (raw_port_status & PORT_POWER)
   819                          && (bus_state->suspended_ports & (1 << 
wIndex))) {
   820                  bus_state->suspended_ports &= ~(1 << wIndex);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: Binary data

Reply via email to