On Wed, Dec 02, 2015 at 03:24:30AM +0300, Yury Norov wrote: > On Tue, Dec 01, 2015 at 12:30:56PM +0100, Arnd Bergmann wrote: > > On Tuesday 01 December 2015 12:01:12 Andreas Schwab wrote: > > > Arnd Bergmann <[email protected]> writes: > > > > > > > On Tuesday 01 December 2015 10:20:59 Andreas Schwab wrote: > > > >> Yury Norov <[email protected]> writes: > > > >> > > > >> > There's a tricky bug with signal stack, that Andreas also discovered. > > > >> > > > >> That was only a confusion about the compat state of sys_rt_sigaction. > > > >> It just requires making sure glibc uses the correct (64bit layout) > > > >> struct kernel_sigaction. > > > > > > > > I don't think we need to use the 64-bit version of sigaction, both > > > > kernel and libc are simpler if we use the normal 32-bit version. > > > > > > Since glibc has to do the conversion anyway (due to sigset_t), using the > > > 64bit layout avoids a second conversion in the kernel. > > > > I don't get the part about sigset_t. Why would glibc want to use the > > 64-bit layout? This one looks like one of the cases where we absolutely > > want to use the 32-bit layout or otherwise get into big trouble if > > we ever want to support native ILP32 kernels. > > > > Arnd > > So, we drop patch #6, and use 32-bit layout for all signal structures. > > Correct?
I would vote for this as well. I think it probably removes patch 12 as well (COMPAT_USE_NATIVE_SIGINFO). -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
