On Thu, December 3, 2015 08:39, Philipp Zabel wrote:
> Am Mittwoch, den 02.12.2015, 21:03 +0000 schrieb Simon Arlott:
>> +periph_soft_rst: reset-controller {
>> + compatible = "brcm,bcm63168-reset", "brcm,bcm6345-reset";
>> + regmap = <&periph_cntl>;
>> + offset = <0x10>;
>> +
>> + #reset-cells = <1>;
>> +};
>
> I would have written it something like this:
>
> periph_cntl: ... {
> compatible = "syscon", "simple-mfd";
> #address-cells = <1>;
> #size-cells = <1>;
>
> periph_soft_rst: reset-controller {
> compatible = "brcm,bcm6345-reset";
> reg = <0x10 0x4>;
> #reset-cells = <1>;
> };
> };
>
> for a device that is only controlled through a syscon.
Rob, do you want me to change this or is my version ok?
> The driver itself looks good to me.
>
> best regards
> Philipp
>
>
--
Simon Arlott
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
