Em Mon, Dec 14, 2015 at 10:46:07AM +0000, Matt Fleming escreveu: > On Sat, 12 Dec, at 07:07:02PM, Markus Trippelsdorf wrote: > > perf doesn't build with gcc-6 because of several misleading-indentation > > warnings, e.g.: > > > > arch/x86/tests/intel-cqm.c: In function ‘spawn’: > > arch/x86/tests/intel-cqm.c:21:3: error: statement is indented as if it were > > guarded by... [-Werror=misleading-indentation] > > sleep(5); > > ^~~~~ > > > > arch/x86/tests/intel-cqm.c:20:2: note: ...this ‘while’ clause, but it is not > > while(1); > > ^~~~~ > > > > Signed-off-by: Markus Trippelsdorf <[email protected]> > > > > diff --git a/tools/perf/arch/x86/tests/intel-cqm.c > > b/tools/perf/arch/x86/tests/intel-cqm.c > > index d28c1b6a3b54..fa5d17af88b7 100644 > > --- a/tools/perf/arch/x86/tests/intel-cqm.c > > +++ b/tools/perf/arch/x86/tests/intel-cqm.c > > @@ -17,7 +17,7 @@ static pid_t spawn(void) > > if (pid) > > return pid; > > > > - while(1); > > + while(1) > > sleep(5); > > return 0; > > } > > Whoops. Good catch. > > Reviewed-by: Matt Fleming <[email protected]>
So, Markus, can you split this in three patches, stating that in some cases its just cosmetic stuff while in others really a bug got fixed, adding the Reviewed-by: tag for the cqm one? And acked-by for all, from Ingo? - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
