On Thu, Jan 07, 2016 at 01:39:28PM +0100, Jiri Olsa wrote:
> Currently we don't synthesize data mmap by default. It depends
> on -d option, that enables data address sampling.
>
> But we've seen cases (softice) where DWARF unwinder went through
> non executable mmaps, which we need to lookup in MAP__VARIABLE tree.
>
> Making data mmaps to be synthesized for dwarf unwind as well.
>
> Reported-by: Noel Grandin <[email protected]>
> Link: http://lkml.kernel.org/n/[email protected]
> Signed-off-by: Jiri Olsa <[email protected]>
> ---
> tools/perf/builtin-record.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index 9c5cdc2c4471..465bde77f49b 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -815,8 +815,11 @@ int record_parse_callchain_opt(const struct option *opt,
> }
>
> ret = parse_callchain_record_opt(arg, &callchain_param);
> - if (!ret)
> + if (!ret) {
> + /* Enable data address sampling for DWARF unwind. */
> + record->sample_address = true;
How does it guarantee that it enables data address sampling only for
DWARF unwind? Maybe you want this?
if (callchain_param.record_mode == CALLCHAIN_DWARF)
record->sample_address = true;
Thanks,
Namhyung
> callchain_debug();
> + }
>
> return ret;
> }
> --
> 2.4.3
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
