2016-01-25 13:25+0100, Paolo Bonzini:
> On 22/01/2016 15:01, Radim Krcmár wrote:
>>> for (i = 0; i <= mod; i++) {
>>> idx = find_next_bit(bitmap, bitmap_size, idx + 1);
>>> BUG_ON(idx == bitmap_size);
>>> }
>
> WARN_ON, not BUG_ON.Callers don't check the return value for an error, because every error is a BUG now. I think that we should check if we return bitmap_size. (Current paths could dereference NULL or throw unrelated warnings.) Also, WARN_ON_ONCE?

