Re: [PATCH V5 10/11] soc: mediatek: PMIC wrap: add mt6323 slave support

[Matthias Brugger]

On 07/02/16 11:42, John Crispin wrote:
Add support for MT6323 slaves. This PMIC can be found on MT2701 and MT7623
EVB. The only function that we need to touch is pwrap_init_cipher().

Signed-off-by: John Crispin <blo...@openwrt.org>
---
  drivers/soc/mediatek/mtk-pmic-wrap.c |   47 ++++++++++++++++++++++++++++++++++
  1 file changed, 47 insertions(+)

diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c 
b/drivers/soc/mediatek/mtk-pmic-wrap.c
index 2628271..5fbdd5c 100644
--- a/drivers/soc/mediatek/mtk-pmic-wrap.c
+++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
@@ -91,6 +91,31 @@ enum dew_regs {
        PWRAP_DEW_CIPHER_RDY,
        PWRAP_DEW_CIPHER_MODE,
        PWRAP_DEW_CIPHER_SWRST,
+
+       /* MT6323 only regs */
+       PWRAP_DEW_CRC_SWRST,
+       PWRAP_DEW_CIPHER_EN,
+       PWRAP_DEW_RDDMY_NO,
+       PWRAP_DEW_RDATA_DLY_SEL,
+};

We just use PWRAP_DEW_CIPHER_EN, right?
I think it makes the code more readable if we just declare the registers 
we actually need.

Thanks,
Matthias