From: kbuild test robot <[email protected]>

 Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
 threaded IRQs without a primary handler need to be requested with
 IRQF_ONESHOT, otherwise the request will fail.

 So pass the IRQF_ONESHOT flag in this case.

Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci

CC: Laxman Dewangan <[email protected]>
Signed-off-by: Fengguang Wu <[email protected]>
Signed-off-by: Valentin Rothberg <[email protected]>
---
 drivers/rtc/rtc-max77686.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c
index 5e924f3cde90..027ee7ebfff4 100644
--- a/drivers/rtc/rtc-max77686.c
+++ b/drivers/rtc/rtc-max77686.c
@@ -742,8 +742,8 @@ static int max77686_rtc_probe(struct platform_device *pdev)
                goto err_rtc;
        }
 
-       ret = request_threaded_irq(info->virq, NULL, max77686_rtc_alarm_irq, 0,
-                                  "rtc-alarm1", info);
+       ret = request_threaded_irq(info->virq, NULL, max77686_rtc_alarm_irq,
+                                  IRQF_ONESHOT, "rtc-alarm1", info);
        if (ret < 0) {
                dev_err(&pdev->dev, "Failed to request alarm IRQ: %d: %d\n",
                        info->virq, ret);
-- 
2.5.0

Reply via email to