On 18/02/2016 at 17:13:18 +0900, Krzysztof Kozlowski wrote : > On 18.02.2016 17:06, Valentin Rothberg wrote: > > From: kbuild test robot <[email protected]> > > > > Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") > > threaded IRQs without a primary handler need to be requested with > > IRQF_ONESHOT, otherwise the request will fail. > > > > So pass the IRQF_ONESHOT flag in this case. > > > > Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci > > > > CC: Laxman Dewangan <[email protected]> > > Signed-off-by: Fengguang Wu <[email protected]> > > Signed-off-by: Valentin Rothberg <[email protected]> > > --- > > drivers/rtc/rtc-max77686.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > Nack, because: > 1. AFAIR this is a false positive. > 2. Was it tested? Was it reproduced? Was the bug actually spotted or > just coccicheck pointed this and you assumed that "request will fail"? > > Coccicheck is a great tool... but not necessarily for pointing run-time > bugs. >
Definitively a false positive. Julia, I've been receiving quite a lot of those, is it possible to add a note that this generates false positives to try to stop people from blindly sending patches? I would have expected Valentin to know that though. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
