On 21/02/16 20:59, Joe Perches wrote: > On Sun, 2016-02-21 at 20:41 +0000, Jonathan Cameron wrote: >> On 18/02/16 15:53, Daniel Baluta wrote: >>> This makes code consistent around inv_mpu6050 driver and >>> fixes the following checkpatch.pl warning: >>> CHECK: Alignment should match open parenthesis >>> >>> Note that there were few cases were it was not possible to >>> fix this due to making the line too long, but we can live with that. >>> >>> Signed-off-by: Daniel Baluta <[email protected]> >> Applied > [] >>> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c >>> b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c > [] >>> @@ -217,11 +217,10 @@ static int inv_mpu6050_sensor_show(struct >>> inv_mpu6050_state *st, int reg, >>> return IIO_VAL_INT; >>> } >>> >>> -static int inv_mpu6050_read_raw(struct iio_dev *indio_dev, >>> - struct iio_chan_spec const *chan, >>> - int *val, >>> - int *val2, >>> - long mask) { >>> +static int >>> +inv_mpu6050_read_raw(struct iio_dev *indio_dev, >>> + struct iio_chan_spec const *chan, >>> + int *val, int *val2, long mask) { > > Ideally, you'd also convert this form to use > the open brace on a new line like: > > static int > inv_mpu6050_read_raw(struct iio_dev *indio_dev, > struct iio_chan_spec const *chan, > int *val, int *val2, long mask) > { > Good point - as it fitted nicely in with Daniel's patch I applied a quick fixup doing this one and the write_raw.
Thanks Joe, Jonathan
