On Wed, 2015-11-11 at 21:27 +0100, Thomas Betker wrote:
>
> int jffs2_flash_direct_writev(struct jffs2_sb_info *c, const struct kvec
> *vecs,
> unsigned long count, loff_t to, size_t *retlen)
> {
> + int ret;
> +
> + ret = mtd_writev(c->mtd, vecs, count, to, retlen);
> +
> if (!jffs2_is_writebuffered(c)) {
> if (jffs2_sum_active()) {
> int res;
> +
> + if (ret ||
> + *retlen != iov_length((struct iovec *) vecs,
> count))
> + return ret;
> +
> res = jffs2_sum_add_kvec(c, vecs, count, (uint32_t)
> to);
> if (res) {
> return res;OK... but perhaps we can dispense with the separate 'ret' and 'res' variables and the rats nest of conditions, and do something like: int ret; ret = mtd_writev(…); if (!ret && *retlen == iov_length(…) && !jffs2_is_writebuffered(c) && jffs2_sum_active()) ret = jffs2_sum_add_kvec(…); return ret; -- David Woodhouse Open Source Technology Centre [email protected] Intel Corporation
smime.p7s
Description: S/MIME cryptographic signature
